[SDTEST-635] gem datadog 2.3 is now minimal required version #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 98.92% 98.92% -0.01%
==========================================
Files 261 261
Lines 12387 12386 -1
Branches 559 559
==========================================
- Hits 12254 12253 -1
Misses 133 133 ☔ View full report in Codecov by Sentry. |
romainkomorndatadog
approved these changes
Aug 26, 2024
Merged
|
Nice! I love the "let's use one gem to push folks to upgrade the other" :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now datadog-ci library requires gem datadog version to be at least 2.3 to be able to use agentless telemetry, so I bump minimum required version in gemspec
Motivation
We are going to release internal Datadog telemetry in agentless mode soon.
How to test the change?
Covered by unit tests